[Radiant] Archives by Month??? PROBLEM FOUND, NOW WHAT?

[bodhi]

On 11/08/2006, at 2:06 PM, John W. Long wrote:

> Andrew Barnett wrote:
>> BUT, STRFTIME('%m' returns a character value, such as '06', whereas
>> it's being compared to the integer 6. I tested in sqlite3 and no rows
>> returned. Wow, 17 years of Oracle experience counts for something in
>> this Web world.
>>
>> So, strftime needs to be wrapped with a string-to-integer conversion,
>> yes?
>
> That sounds fine to me. Can you or someone else get me a unit test that
> reproduces the problem? Maybe even a patch that fixes it?

The unit tests were already broken for sqlite3 in regard to this 
problem. I just put a patch on trac [1] to solve it. I'm also running 
on OS X (10.3.9) and sqlite3 (from darwinports).


Also there was a typo in page_context.test.rb:

def test_tag_children_each_attributes_with_invalid_limit

should be:

def test_tag_children_each_attributes_with_invalid_order

I've put it in trac [2] so it doesn't get forgotten :)

Bodhi

[1] http://dev.radiantcms.org/radiant/ticket/257
[2] http://dev.radiantcms.org/radiant/ticket/258